From: phillip.wood123@gmail.com
Date: Wed, 10 Apr 2024 15:23:55 GMT
Subject: Re: [PATCH 3/3] t3428: restore coverage for "apply" backend
Message-ID: <5e0ec9eb-2e2c-4cb6-91e2-eef6b5c4300c@gmail.com>
In-Reply-To: <xmqqjzl5z4a9.fsf@gitster.g>

On 10/04/2024 15:22, Junio C Hamano wrote:
> phillip.wood123@gmail.com writes:
> 
>>> Hmph, doesn't this lose coverage for the merge backend, though?
>>
>> I don't think so, we had coverage for the merge backend from the other
>> tests before 2ac0d6273f as all of the other tests in this file use the
>> merge backend. We're no longer testing "--signoff" without specifying
>> some other option that selects a backend but it seems unlikely that we
>> could break that without breaking one of the other tests.
> 
> OK, so we have "rebase --merge --signoff" tested elsewhere and we
> are replacing "rebase --signoff" with "rebase --apply --signoff"?

Exactly

> Thanks.
>