From: Kaartic Sivaraam Date: Mon, 14 Sep 2026 15:08:19 GMT Subject: Re: [PATCH v3 00/13] Fix inconsistent ref storage format terminology Message-ID: <5e062976-d584-496d-84e0-e4b59c8f6876@gmail.com> In-Reply-To: <20260909-b4-pks-unify-ref-storage-format-v3-0-ca041fb40ad8@pks.im> On 9/9/26 16:42, Patrick Steinhardt wrote: > > Changes in v3: > - Add breadcrumbs for the old names to our documentation. > - Use `OPT_ALIAS()` instead of manually aliasing the options. > - Fix a comment in one of our tests that still referred to the v1 > "--ref-storage=" option. > - Print the correct environment variables in error messages. > - Also rename GIT_TEST_DEFAULT_REF_FORMAT. > - Don't adapt "ref-storage-format.adoc", as that documentation is also > shared with commands that don't support URIs yet. > - Link to v2: https://patch.msgid.link/20260907-b4-pks-unify-ref-storage-format-v2-0-6733c90ca5b0@pks.im > This version does look good to me too. I just had one though while going through the patches. We appear to be rewritten the tests using only the newer variant of the arguments / environment variables. I wonder if we might also need a test or two to ensure the deprecated variants work as expected too. -- Sivaraam