From: Jakub Narębski <jnareb@gmail.com>
Date: Fri, 18 Nov 2016 21:36:45 GMT
Subject: Re: [PATCH v7 10/17] ref-filter: introduce refname_atom_parser_internal()
Message-ID: <5df0a607-4d83-8211-457a-96d7bde46eff@gmail.com>
In-Reply-To: <20161108201211.25213-11-Karthik.188@gmail.com>

W dniu 08.11.2016 o 21:12, Karthik Nayak pisze:
> From: Karthik Nayak <karthik.188@gmail.com>
> 
> Since there are multiple atoms which print refs ('%(refname)',
> '%(symref)', '%(push)', '%upstream'), it makes sense to have a common

Minor typo; it should be: "%(upstream)"

> ground for parsing them. This would allow us to share implementations of
> the atom modifiers between these atoms.
> 
> Introduce refname_atom_parser_internal() to act as a common parsing
> function for ref printing atoms. This would eventually be used to
> introduce refname_atom_parser() and symref_atom_parser() and also be
> internally used in remote_ref_atom_parser().
> 
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
> ---
[...]

> +static void refname_atom_parser_internal(struct refname_atom *atom,
> +					 const char *arg, const char *name)
> +{
> +	if (!arg)
> +		atom->option = R_NORMAL;
> +	else if (!strcmp(arg, "short"))
> +		atom->option = R_SHORT;
> +	else if (skip_prefix(arg, "strip=", &arg)) {
> +		atom->option = R_STRIP;
> +		if (strtoul_ui(arg, 10, &atom->strip) || atom->strip <= 0)
> +			die(_("positive value expected refname:strip=%s"), arg);
> +	} 	else
          ^^^^^^

It looks like you have spurious tab here.

> +		die(_("unrecognized %%(%s) argument: %s"), name, arg);
> +}
> +
>  static void remote_ref_atom_parser(struct used_atom *atom, const char *arg)
>  {
>  	struct string_list params = STRING_LIST_INIT_DUP;
>