From: Martin Ågren Date: Fri, 06 Oct 2017 20:12:06 GMT Subject: [PATCH v3 04/12] tempfile: fix documentation on `delete_tempfile()` Message-ID: <5de134ca8594de22f2a0b738824f9b5176ae6c00.1507320376.git.martin.agren@gmail.com> In-Reply-To: The function has always been documented as returning 0 or -1. It is in fact `void`. Correct that. As part of the rearrangements we lose the mention that `delete_tempfile()` might set `errno`. Because there is no return value, the user can't really know whether it did anyway. Signed-off-by: Martin Ågren Signed-off-by: Junio C Hamano --- tempfile.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tempfile.h b/tempfile.h index b8f4b5e14..450908b2e 100644 --- a/tempfile.h +++ b/tempfile.h @@ -68,10 +68,10 @@ * `create_tempfile()` returns an allocated tempfile on success or NULL * on failure. On errors, `errno` describes the reason for failure. * - * `delete_tempfile()`, `rename_tempfile()`, and `close_tempfile_gently()` - * return 0 on success. On failure they set `errno` appropriately and return - * -1. `delete` and `rename` (but not `close`) do their best to delete the - * temporary file before returning. + * `rename_tempfile()` and `close_tempfile_gently()` return 0 on success. + * On failure they set `errno` appropriately and return -1. + * `delete_tempfile()` and `rename` (but not `close`) do their best to + * delete the temporary file before returning. */ struct tempfile { -- 2.15.0.rc0