From: Johannes Sixt Date: Tue, 19 Mar 2019 06:54:25 GMT Subject: Re: [PATCH 4/4] gc docs: downplay the usefulness of --aggressive Message-ID: <5cf21eee-a46f-2657-7bf3-e4963cf1c56b@kdbg.org> In-Reply-To: <20190318161502.7979-5-avarab@gmail.com> Am 18.03.19 um 17:15 schrieb Ævar Arnfjörð Bjarmason: > +Using this option may optimize for disk space at the expense of > +runtime performance. See the `--depth` and `--window` documentation in > +linkgit:git-repack[1]. It is not recommended that this option be used > +to improve performance for a given repository without running tailored > +performance benchmarks on it. It may make things better, or worse. Not > +using this at all is the right trade-off for most users and their > +repositories. > ++ > +The effects of this option are persistent to the extent that > +`gc.autoPackLimit` and friends don't cause a consolidation of existing > +pack(s) generated with this option. The first paragraph talks about potential downsides. And I think that the second paragraph attempts to tell me how I can back out if I'm hit by those downsides. But I have not the slightest idea how to read this sentence and know what I have to do. -- Hannes