From: Xing Xin Date: Thu, 30 May 2024 08:48:54 GMT Subject: Re:Re: [PATCH v3 3/4] fetch-pack: expose fsckObjects configuration logic Message-ID: <5cb91961.8ebd.18fc8b01748.Coremail.bupt_xingxin@163.com> In-Reply-To: At 2024-05-29 01:24:35, "Junio C Hamano" wrote: [snip] >The original before it was made into a helper function was written >as a cascade of ?: operators, because it had to be a single >expression. As the body of a helper function, we now can sprinkle >multiple return statements in it. I think the way that is easiest >to understand is > > /* the most specific, if specified */ > if (fetch_fsck_objects >= 0) > return fetch_fsck_objects; > /* the less specific, catch-all for both directions */ > if (transfer_fsck_objects >= 0) > return transfer_fsck_objects; > /* the fallback hardcoded default */ > return 0; > >without the /* comments */. Applied, thanks! Xing Xin