From: Torsten Bögershausen <tboegi@web.de>
Date: Sat, 28 May 2016 08:17:19 GMT
Subject: Re: [PATCH v8 0/9] connect: various cleanups
Message-ID: <5ba52c0a-2b8f-91af-d823-9519cdb9f67c@web.de>
In-Reply-To: <20160528053354.GA3860@glandium.org>

On 28.05.16 07:33, Mike Hommey wrote:
> On Sat, May 28, 2016 at 07:02:01AM +0200, Torsten Bögershausen wrote:
>> On 27.05.16 23:59, Mike Hommey wrote:
>>> On Fri, May 27, 2016 at 04:24:20PM +0200, Torsten Bögershausen wrote:
>>>> On 27.05.16 04:27, Mike Hommey wrote:
>>>>> Changes from v7:
>>>>> - Fixed comments.
>>>>>
>>>>> Mike Hommey (9):
>> All in all, a great improvement.
>> 2 things left.
>> - The comment about [] is now stale, isn't it ?
> No, it's still valid at this point, that's what the 2nd argument to
> host_end (0) does.
>
> Mike

The protocol (specific) code doesn't do this anymore, 
because that is now common to all protocols.


       /*
        * Don't do destructive transforms now, the
        * '[]' unwrapping is done in get_host_and_port()
        */