From: Shaoxuan Yuan Date: Wed, 10 Aug 2022 00:31:10 GMT Subject: Re: [PATCH v2 0/4] rm: integrate with sparse-index Message-ID: <5b093198-8dc0-6dcc-8a3b-6762b6dc11bf@gmail.com> In-Reply-To: <8a76428d-e236-88bc-ec67-356b4c6f67fa@github.com> On 8/10/2022 8:27 AM, Victoria Dye wrote: > Shaoxuan Yuan wrote: >> ## Changes since PATCH v1 ## >> >> 1. Move `ensure_not_expanded` test from the first patch to the last one. >> >> 2. Mention the parameter of `pathspec_needs_expanded_index()` is >>    changed to use `struct index_state`. >> >> 3. Modify `ensure_not_expanded` method to record Git commands' stderr >>    and stdout. >> >> 4. Add a test 'rm pathspec expands index when necessary' to test >>    the expected index expansion when different pathspec is supplied. >> >> 5. Modify p2000 test by resetting the index in each test loop, so the >>    index modification is properly tested. Update the perf stats using >>    the results from the modified test. >> >> ## PATCH v1 info ## >> >> Turn on sparse-index feature within `git-rm` command. >> Add necessary modifications and test them. > > Other than a completely optional recommendation on commit ordering [1], I didn't have any comments on any individual patches. This series looks good to me! > > [1] https://lore.kernel.org/git/2c0cb658-cd5a-420a-d313-6839149b9b40@github.com/ Thanks for reviewing! :) I think I'll just leave the commit ordering as-is. -- Thanks, Shaoxuan