From: Reid Woodbury Jr. Date: Thu, 02 Apr 2015 20:06:00 GMT Subject: Re: git 2.3.4, ssh: Could not resolve hostname Message-ID: <5B043A67-E2FC-4F40-89C5-915B3D893459@rawsound.com> In-Reply-To: <20150402193524.GA21555@peff.net> Yup, removing the colon works in both 2.3.3 and 2.3.4. And I see that the manual doesn't use the colon! (eg. $ git clone ssh://user@server/project.git). The usage of the colon looks normal to my eyes because, for instance, SFTP uses it to set the path on login so this wasn't something I would have even considered. I'm sure I've seen it other places but I can't remember right now. Thanks all for your time. > On Apr 2, 2015, at 12:35 PM, Jeff King wrote: > > On Thu, Apr 02, 2015 at 12:31:14PM -0700, Reid Woodbury Jr. wrote: > >> Ah, understand. Here's my project URL for 'remote "origin"' with a >> more meaningful representation of their internal FQDN: >> >> url = ssh://rwoodbury@systemname.groupname.online:/opt/git/inventory.git >> >> The "online" is their literal internal TLD. > > Thanks. The problem is the extra ":" after "online"; your URL is > malformed. You can just drop that colon entirely. > > I do not think we need to support this syntax going forward (the colon > is meaningless here, and our documentation is clear that it should go > with a port number), but on the other hand, it might be nice to be more > liberal, as we were in v2.3.3 and prior. I'll leave it to Torsten to see > whether supporting that would hurt some of the other cases, or whether > it would make the code too awkward. > > -Peff