From: Wincent Colaiuta <win@wincent.com>
Date: Fri, 14 Dec 2007 07:51:02 GMT
Subject: Re: [PATCH] Don't use the pager when running "git diff --check"
Message-ID: <5A086A2E-16DB-4A3C-92E6-F879189A87FE@wincent.com>
In-Reply-To: <7vy7bxu3w5.fsf@gitster.siamese.dyndns.org>

El 14/12/2007, a las 8:33, Junio C Hamano escribió:

> Junio C Hamano <gitster@pobox.com> writes:
>
>> By the way, there is no reason to make --check and --exit-code  
>> mutually
>> exclusive either.
>
> Perhaps something like this.  Regardless of the exclusivity issue, I
> think the "diff_result_code()" helper function is a good clean-up.

Totally agreed. It replaces some groups of very-similar lines.

I'll integrate these (and the other suggestions) some time this  
morning and post a new version of the series that incorporates all the  
feedback and patch suggestions.

Cheers,
Wincent