From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 16 Aug 2022 09:11:57 GMT
Subject: Re: [PATCH 2/5] rebase: store orig_head as a commit
Message-ID: <59p441po-0o06-7660-r571-9nn8nos2r5q5@tzk.qr>
In-Reply-To: <cced4a48360b4e4a8ce791e9404ac6b37bae4eba.1660576283.git.gitgitgadget@gmail.com>

Hi Phillip,

On Mon, 15 Aug 2022, Phillip Wood via GitGitGadget wrote:

> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>
> Using a struct commit rather than a struct oid to hold orig_head means
> that we error out straight away if branch being rebased does not point
> to a commit. It also simplifies the code than handles finding the
> merge base and fork point as it not longer has to convert from an oid
> to a commit.

Very nice!

The diff is necessarily "chatty", therefore it is especially good that you
separated out this concern into its own, easily-reviewable commit.

Thank you,
Dscho