From: Johannes Sixt <j6t@kdbg.org>
Date: Fri, 16 Dec 2016 18:44:37 GMT
Subject: Re: [PATCH 1/1] mingw: intercept isatty() to handle /dev/null as Git expects it
Message-ID: <5977e71d-da58-7cb0-bc69-343bb3a1341d@kdbg.org>
In-Reply-To: <xmqqy3zfsq4q.fsf@gitster.mtv.corp.google.com>

Am 16.12.2016 um 19:08 schrieb Junio C Hamano:
> Sorry for not having waited for you to chime in before agreeing to
> fast-track this one, and now this is in 'master'.

No reason to be sorry, things happen... Dscho's request for 
fast-tracking was very reasonable, and the patch looked "obviously 
correct". I lacked time to test it promptly, and when I finally did, I 
ignored the symptoms because my workflow was a mess and I had to 
concentrate on other things. Only after 'git push' did not report the 
pack progress, was my suspicion raised...

>> Should we not use winansi_get_osfhandle() instead of _get_osfhandle()?

Unfortunately, I'm away from my Windows box over the weekend. It will 
have to wait until Monday before I can test this idea.

-- Hannes