From: David Aguilar Date: Sun, 22 Sep 2013 08:52:17 GMT Subject: Re: [PATCH v2] build: add default configuration Message-ID: <5940c6ca-86f4-4a57-bc9e-41a73842cc6d@email.android.com> In-Reply-To: <523e815966074_547c41e7c16566@nysa.mail> Felipe Contreras wrote: >David Aguilar wrote: >> Felipe Contreras wrote: >> >On Sat, Sep 21, 2013 at 1:58 PM, Johannes Sixt wrote: >> >> Am 21.09.2013 13:47, schrieb Felipe Contreras: >> >>> diff --git a/Makefile b/Makefile >> >>> index 3588ca1..18081bf 100644 >> >>> --- a/Makefile >> >>> +++ b/Makefile >> >>> @@ -1010,7 +1010,7 @@ ifndef sysconfdir >> >>> ifeq ($(prefix),/usr) >> >>> sysconfdir = /etc >> >>> else >> >>> -sysconfdir = etc >> >>> +sysconfdir = $(prefix)/etc >> >> >> >> Not good: There is a reason why this is a relative path. Please >dig >> >the >> >> history, it's pretty clear. >> > >> >It's pretty clear it's *not* a relative path. >> > >> >What is relative about 'sysconfdir = /etc'? >> >> Thanks Johannes. Felipe, the history and this comment from the >makefile should shed some light on it: >> >> # Among the variables below, these: >> # gitexecdir >> # template_dir >> # sysconfdir >> # can be specified as a relative path some/where/else; >> # this is interpreted as relative to $(prefix) and "git" at >> # runtime figures out where they are based on the path to the >executable. > >They *can* be, but not necessarily so, and in particular sysconfig for >probably >99% of the users is not relative, it's /etc. This makes Git relocatable. MsysGit has many more users then developers, and represents a pretty large chunk of users. -- David