From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Mon, 06 Jun 2016 14:16:29 GMT
Subject: Re: [PATCH] completion: complete --move for git branch
Message-ID: <582640631.360243.1465222588996.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <1465218971-14118-1-git-send-email-ville.skytta@iki.fi>

Hi,

Ville Skyttä <ville.skytta@iki.fi> writes:
>          while [ $c -lt $cword ]; do
>                  i="${words[c]}"
>                  case "$i" in
> -                -d|-m)        only_local_ref="y" ;;
> -                -r)        has_r="y" ;;
> +                -d|-m|--move)        only_local_ref="y" ;;

"While you're at it" you might want to do the same thing for
`--delete`.

> +                -r)                has_r="y" ;;

You are introducing an additional tab here that you probably didn't
want.

>                  esac
>                  ((c++))
>          done
> @@ -979,7 +979,7 @@ _git_branch ()
>                          --color --no-color --verbose --abbrev= --no-abbrev
>                          --track --no-track --contains --merged --no-merged
>                          --set-upstream-to= --edit-description --list
> -                        --unset-upstream
> +                        --unset-upstream --move
>                          "
>                  ;;
>          *)

Thanks,
Rémi