From: Phillip Wood <phillip.wood123@gmail.com>
Date: Thu, 22 Oct 2026 14:29:30 GMT
Subject: Re: [PATCH v4 1/1] archive-zip: refactor 'path too long' error message to use Q_()
Message-ID: <57e076d3-cfea-475d-b68d-a9f36746db35@gmail.com>
In-Reply-To: <20261020183908.861-2-kerylefondji7@gmail.com>

Hi Keryle

On 20/10/2026 19:39, kerylefondji7@gmail.com wrote:
> > diff --git a/archive-zip.c b/archive-zip.c
> index 6f73ca6d58..5ab3ba786f 100644
> --- a/archive-zip.c
> +++ b/archive-zip.c
> @@ -328,8 +328,10 @@ static int write_zip_entry(struct archiver_args *args,
>   	}
>   >   	if (pathlen > 0xffff) {
> -		return error(_("path too long (%d chars, SHA1: %s): %s"),
> -				(int)pathlen, oid_to_hex(oid), path);
> +	 return error(Q_("path too long (%d char, SHA1: %s): %s",
> +	  "path too long (%d chars, SHA1: %s): %s",
> +	 pathlen),
> +		(int)pathlen, oid_to_hex(oid), path);

The indentation is still messed up. If you look at the deleted lines you can see that
we've lost a level of indentation inside the "if" block and the function arguments no
longer line up. It should look like

	if (pathlen > 0xffff) {
		return error(Q_("path too long (%d char, SHA1: %s): %s",
				"path too long (%d chars, SHA1: %s): %s",
				pathlen),
			     (int)pathlen, oid_to_hex(oid), path);
	}

Thanks

Phillip