From: Derrick Stolee Date: Tue, 16 Feb 2021 11:35:26 GMT Subject: Re: [PATCH 2/5] commit-graph: remove redundant handling of -h Message-ID: <57d86d79-e33e-053d-3282-0b36145358fb@gmail.com> In-Reply-To: <20210215184118.11306-3-avarab@gmail.com> On 2/15/2021 1:41 PM, Ævar Arnfjörð Bjarmason wrote: > +test_expect_success 'usage' ' > + test_expect_code 129 git commit-graph -h 2>err && > + ! grep error: err > +' I think this test already exists in t0012-help.sh, since it tests bogus options for all of the builtins. (I can guarantee that I wouldn't have thought to add the check without some instance like that.) Thanks, -Stolee