From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Wed, 27 Aug 2025 09:21:18 GMT
Subject: Re: [PATCH] curl: add support for curl_global_trace() components
Message-ID: <57a79b29-0e65-482c-b0a8-1e73744ad5f6@app.fastmail.com>
In-Reply-To: <20250827080702.GA3572995@coredump.intra.peff.net>

On Wed, Aug 27, 2025, at 10:07, Jeff King wrote:
> This patch teaches Git's http code to accept a component list from the
> environment and pass it into curl_global_trace(). We can then use that
> in the test to enable the correct component.

s/This patch teaches Git's http code/Teach Git's http code/

SubmittingPatches “imperative-mood”

>
> It should be safe to do so unconditionally. In older versions of curl
> which don't support this call, setting the environment variable is a
> noop. Likewise, any versions of curl which don't recognize the "socks"
> component should silently ignore it. The manpage for curl_global_trace()
> says this:
>
>   The config string is a list of comma-separated component names. Names
>   are case-insensitive and unknown names are ignored. The special name
>   "all" applies to all components. Names may be prefixed with '+' or '-'
>   to enable or disable detailed logging for a component.
>
>   The list of component names is not part of curl's public API. Names may
>   be added or disappear in future ver‐ sions of libcurl. Since unknown

s/ver‐ sions/versions/

>   names are silently ignored, outdated log configurations does not cause
>   errors when upgrading libcurl. Given that, some names can be expected
>   to be fairly stable and are listed below for easy reference.
>[snip]

-- 
Kristoffer Haugsbakk