From: Remi Galan Alfonso Date: Wed, 27 May 2015 13:19:19 GMT Subject: Re: [PATCH/RFC 2/2] git rebase -i: Warn removed or dupplicated commits Message-ID: <579982712.39028.1432732759119.JavaMail.zimbra@ensimag.grenoble-inp.fr> In-Reply-To: Thank you for reviewing the code. Eric Sunshine writes: > > + # To uppercase > > + checkLevel=$(echo "$checkLevel" | tr '[:lower:]' '[:upper:]') > > Is there precedence elsewhere for recognizing uppercase and lowercase > variants of config values? It seems to be commonly used when parsing options in the C files through strcasecmp. For exemple, in config.c:818 : if (!strcmp(var, "core.safecrlf")) { if (value && !strcasecmp(value, "warn")) { [...] However we didn't see any precedence in shell files. Do you think we should remove it?