From: Jakub Narębski Date: Mon, 29 Aug 2016 13:48:10 GMT Subject: Re: [PATCH 01/20] cache: convert struct cache_entry to use struct object_id Message-ID: <577f6266-42ec-6c7b-8b21-1e4997f2b816@gmail.com> In-Reply-To: <20160828232757.373278-2-sandals@crustytoothpaste.net> W dniu 29.08.2016 o 01:27, brian m. carlson pisze: > Convert struct cache_entry to use struct object_id by applying the > following semantic patch and the object_id transforms from contrib: > > @@ > struct cache_entry E1; > @@ > - E1.sha1 > + E1.oid.hash > > @@ > struct cache_entry *E1; > @@ > - E1->sha1 > + E1->oid.hash I wonder if writing this patch series (or rather the following one) would be helped by using one of semantic patch tools, such as Coccinelle[1], spdiff[2], or Undebt[3]... [1]: http://coccinelle.lip6.fr/ [2]: http://www.diku.dk/~jespera/doc.html [3]: http://engineeringblog.yelp.com/2016/08/undebt-how-we-refactored-3-million-lines-of-code.html Best, -- Jakub Narębski