From: René Scharfe <l.s.r@web.de>
Date: Fri, 08 Jul 2016 18:44:30 GMT
Subject: Re: [PATCH 0/8] write_file cleanups
Message-ID: <577FF48E.4060905@web.de>
In-Reply-To: <20160708090400.GA26594@sigill.intra.peff.net>

Am 08.07.2016 um 11:04 schrieb Jeff King:
> Here it is. There actually weren't that many spots to clean up, as quite
> a few of them have a "twist" where they want to do something clever,
> like open the file and feed the descriptor to a sub-function, or open
> with funny things like O_EXCL.
>
> But still, the diffstat is pleasing:
>
>   builtin/am.c     | 25 +++++++----------
>   builtin/branch.c |  5 +---
>   builtin/config.c |  2 +-
>   builtin/merge.c  | 45 ++++--------------------------
>   cache.h          | 17 ++++++++++--
>   wrapper.c        | 52 ++++++++---------------------------
>   6 files changed, 44 insertions(+), 102 deletions(-)
>
> and that even includes adding some function documentation.

Haha, feels like Candy Crush. :)

(Sent a single small patch, lots of places get patched as if by magic.)

Thanks,
René