From: David Turner <novalis@novalis.org>
Date: Sat, 25 Jun 2016 19:21:06 GMT
Subject: Re: [PATCH v12 04/20] index-helper: new daemon for caching index and related stuff
Message-ID: <576ED9A2.8070202@novalis.org>
In-Reply-To: <CACsJy8CftPGmrKP8Yeok90T9=whzj69bfE3_X6wHyWOEp6vRzg@mail.gmail.com>

On 06/25/2016 10:33 AM, Duy Nguyen wrote:
>> +               /*
>> +                * Our connection to the client is blocking since a client
>> +                * can always be killed by SIGINT or similar.
>> +                */
>> +               set_socket_blocking_flag(client_fd, 0);
>
> Out of curiosity, do we really need this? I thought default behavior
> was always blocking (and checked linux kernel, it seemed to agree with
> me). Maybe for extra safety because other OSes may default to
> something else?

Yes -- see this bug report for details:
https://bugs.python.org/issue7995