From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Mon, 13 Jun 2016 07:16:05 GMT
Subject: Re: [PATCH v2 5/6] lock_ref_for_update(): make error handling more uniform
Message-ID: <575E5DB5.8040109@alum.mit.edu>
In-Reply-To: <1465585279.8278.2.camel@frank>

On 06/10/2016 09:01 PM, David Turner wrote:
> On Fri, 2016-06-10 at 10:14 +0200, Michael Haggerty wrote:
> 
>>  /*
>> + * Check whether the REF_HAVE_OLD and old_oid values stored in update
>> + * are consistent with the result read for the reference. error is
>> + * true iff there was an error reading the reference; otherwise, oid
> 
> "error" is not a thing here?

You're right; thanks for the feedback. I'll include it in the reroll
that I'm about to do.

Michael