From: Johannes Sixt <j6t@kdbg.org>
Date: Sat, 11 Jun 2016 08:17:47 GMT
Subject: Re: [PATCH v6 31/44] run-command: make dup_devnull() non static
Message-ID: <575BC92B.4080401@kdbg.org>
In-Reply-To: <20160610201118.13813-32-chriscool@tuxfamily.org>

Am 10.06.2016 um 22:11 schrieb Christian Couder:
> --- a/run-command.c
> +++ b/run-command.c
> @@ -85,7 +85,7 @@ static inline void close_pair(int fd[2])
>   }
>
>   #ifndef GIT_WINDOWS_NATIVE
> -static inline void dup_devnull(int to)
> +void dup_devnull(int to)

I'm not adding arguments to what we've heard on whether to use /dev/null 
in this series or not. But if the outcome is to keep this patch, please 
remove the #ifndef that we see in the context lines (and the matching 
#endif), too. Otherwise, the build fails on Windows for each patch in 
the series until this change is reverted in patch 42/44.

-- Hannes