From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Fri, 10 Jun 2016 06:30:52 GMT
Subject: Re: [PATCH 2/5] t1404: document function test_update_rejected
Message-ID: <575A5E9C.2050308@alum.mit.edu>
In-Reply-To: <xmqqa8iujqkv.fsf@gitster.mtv.corp.google.com>

On 06/09/2016 06:05 PM, Junio C Hamano wrote:
> Michael Haggerty <mhagger@alum.mit.edu> writes:
> 
>> On 06/07/2016 06:57 PM, Johannes Sixt wrote:
>>> Am 07.06.2016 um 13:50 schrieb Michael Haggerty:
>>>>   test_update_rejected () {
>>>> +    local prefix before pack create error &&
>>>
>>> Do we want to add more of unportable 'local' declarations?
>>
>> Sorry, I forgot that `local` is not in the POSIX standard.
> 
> Regarding portability we say three things.
> 
>  * It is supported practically everywhere, and it is even in POSIX,
>    so let's use it.
> 
>  * Even this is not in POSIX, it is supported practically
>    everywhere, and it is too cumbersome to do things without using
>    it, so let's use it.
> 
>  * It is not available in some platforms we (collectively) still
>    care; it is not even in POSIX.  Don't use it.
> 
> I think "local" falls into the third one.
> 
> : bash; ksh
> $ v=1
> $ f () { local v; v=2; echo f; }
> $ f
> ksh: local: not found [No such file or directory]
> f
> $ echo $v
> 2
> $ exit
> : bash;

OK, I didn't realize that we still support ksh. I will make the change.

Michael