From: Jonathan del Strother Date: Thu, 21 Jan 2010 06:08:37 GMT Subject: Re: [PATCH] Fix memory corruption when .gitignore does not end by \n Message-ID: <57518fd11001202208x3dfd68f6p793f77cb85534923@mail.gmail.com> In-Reply-To: 2010/1/21 Nguyen Thai Ngoc Duy : > On 1/21/10, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy   writes: >> >>  >  This patch causes a crash for me. Not sure if it does for anybody else. >> >> >> I am puzzled.  What do you mean by this?  If this patch makes the code >>  crash, then it is not a fix.  Is this meant as "Jonathan, can you try this >>  patch and tell me what happens, so that I can diagnose the issue better?" >>  patch? > > I mean the t3001 patch in comment part, which removes \n at the end of > .gitignore and crashes the unmodified git. > > IOW I found a problem and this patch (not the t3001 one) should fix > it. Not sure if this causes Jonathan problem though. > >>  Is it better/safer to revert the entire nd/sparse topic from the master in >>  the meantime before we know what is going on? > > I would wait for Jonathan response. If this is not the cause, probably > safer to revert it. > -- > Duy > Think it's all fixed after applying this patch - at least, I can no longer reproduce the crash, whereas I was able to make it fail ~90% of the time before.