From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Mon, 25 Apr 2016 22:14:38 GMT
Subject: Re: [PATCH] remote.c: spell __attribute__ correctly
Message-ID: <571E96CE.80606@ramsayjones.plus.com>
In-Reply-To: <2FDBFACB68254498A8F83367553AED80@PhilipOakley>



On 25/04/16 22:50, Philip Oakley wrote:
> From: "Jeff King" <peff@peff.net>
>> On Mon, Apr 25, 2016 at 05:10:30PM -0400, Jeff King wrote:
>>
>>> It should be handled in git-compat-util.h, which is included by cache.h,
>>> which is included by remote.c.
>>>
>>> There we have:
>>>
>>>   #ifndef __GNUC__
>>>   #ifndef __attribute__
>>>   #define __attribute__(x)
>>>   #endif
>>>   #endif
>>>
>>> which should make it a noop on compilers which don't know about it. Is
>>> VS (or another file) setting __GNUC__?
>>
>> Of course it helps if we spell the name right...

Indeed! ;-)

Not that it matters, but the above #define in git-compat-util.h is not
the relevant definition - msvc will not see it. However, it does see
the #define on line 12 of compat/msvc.h. :-D

ATB,
Ramsay Jones