From: Derrick Stolee <stolee@gmail.com>
Date: Thu, 27 Dec 2018 12:10:11 GMT
Subject: Re: [PATCH v1 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop
Message-ID: <5712b2bf-8a90-42d7-9159-261dd990eb66@gmail.com>
In-Reply-To: <20181226230523.16572-4-randall.s.becker@rogers.com>

On 12/26/2018 6:05 PM, randall.s.becker@rogers.com wrote:
> The NSIG define is also not defined on __TANDEM, so we define it
> here as 100 if it is not defined only for __TANDEM builds.
[snip]
> +#if ! defined NSIG

Why didn't you use "#ifndef" here?

Taking a look at the file, I see both "#ifdef" and "#if defined" but no 
"#if ! defined".

Thanks,

-Stolee