From: Torsten Bögershausen Date: Mon, 11 Apr 2016 04:20:21 GMT Subject: Re: [PATCH 1/3] index-helper: fix UNIX_PATH_MAX redefinition error on cygwin Message-ID: <570B2605.4040305@web.de> In-Reply-To: <570ADAEE.20201@ramsayjones.plus.com> On 04/11/2016 12:59 AM, Ramsay Jones wrote: The header mentions cygwin, but changes it for linux, BSD and Mac OS as well. Is this intentional ? > Signed-off-by: Ramsay Jones > --- > git-compat-util.h | 17 ----------------- > index-helper.c | 4 ++-- > read-cache.c | 2 +- > 3 files changed, 3 insertions(+), 20 deletions(-) > > diff --git a/git-compat-util.h b/git-compat-util.h > index 0e35c13..c90c8c6 100644 > --- a/git-compat-util.h > +++ b/git-compat-util.h > @@ -1043,21 +1043,4 @@ struct tm *git_gmtime_r(const time_t *, struct tm *); > #define getc_unlocked(fh) getc(fh) > #endif > > -#ifdef __linux__ > -#define UNIX_PATH_MAX 108 > -#elif defined(__APPLE__) || defined(BSD) > -#define UNIX_PATH_MAX 104 > -#else Can we use a #elif __CYGWIN__ here to fix the re-definition just for cygwi ?