From: Jean-Noël Avila <jn.avila@free.fr>
Date: Wed, 13 Nov 2024 08:12:20 GMT
Subject: Re: [PATCH v2 5/5] doc: git-diff: apply format changes to config part
Message-ID: <56d27d4d-d1d1-4341-92c0-f12e60ee083e@free.fr>
In-Reply-To: <baeb6c64-eb6f-45ab-ac11-0896dd0adcae@kdbg.org>

Le 12/11/2024 à 19:51, Johannes Sixt a écrit :
> Am 11.11.24 um 17:53 schrieb Jean-Noël Avila via GitGitGadget:
>> @@ -1,18 +1,18 @@
>> -diff.autoRefreshIndex::
>> -	When using 'git diff' to compare with work tree
>> +`diff.autoRefreshIndex`::
>> +	When using `git diff` to compare with work tree
>>  	files, do not consider stat-only changes as changed.
>>  	Instead, silently run `git update-index --refresh` to
>>  	update the cached stat information for paths whose
>>  	contents in the work tree match the contents in the
>>  	index.  This option defaults to true.  Note that this
>> -	affects only 'git diff' Porcelain, and not lower level
>> -	'diff' commands such as 'git diff-files'.
>> +	affects only `git diff` Porcelain, and not lower level
>> +	`diff` commands such as '`git diff-files`.
> 
> A stray ' remained on this line.
> 
>> -diff.srcPrefix::
>> -	If set, 'git diff' uses this source prefix. Defaults to "a/".
>> +`diff.srcPrefix`::
>> +	If set, `git diff` uses this source prefix. Defaults to "a/".
>>  
>> -diff.dstPrefix::
>> -	If set, 'git diff' uses this destination prefix. Defaults to "b/".
>> +`diff.dstPrefix`::
>> +	If set, `git diff` uses this destination prefix. Defaults to "b/".
> 
> You are applying `backticks` to possible values such as `true` and
> `false` later. Then these `a/` and `b/` should also be set in this way.
> 
> -- Hannes
> 

Thank you for your review. Will fix.