From: Dana How Date: Tue, 22 May 2007 18:07:32 GMT Subject: Re: [PATCH] Prevent megablobs from gunking up git packs Message-ID: <56b7f5510705221107m535fa7d2ob0dad6ebb25b9443@mail.gmail.com> In-Reply-To: On 5/22/07, Nicolas Pitre wrote: > On Mon, 21 May 2007, Dana How wrote: > > This patch implements the following: > > 1. git pack-objects takes a new --max-blob-size=N flag, > > with the effect that only blobs less than N KB are written > > to the packfiles(s). If a blob was in a pack but violates > > this limit (perhaps the packs were created by fast-import > > or max-blob-size was reduced), then a new loose object > > is written out if needed so the data is not lost. > > 2. git repack inspects repack.maxblobsize . If set, its > > value is passed to git pack-objects on the command line. > > The user should change repack.maxblobsize , NOT specify > > --max-blob-size=N . > > 3. No other caller of git pack-objects supplies this new flag, > > so other callers see no change. > > > > This patch is on top of the earlier max-pack-size patch, > > because I thought I needed some behavior it supplied, > > but could be rebased on master if desired. > > I think what this patch is missing is a test after all options have been > parsed to prevent --stdout and --max-blob-size to be used together. Yes. I will also update the documentation. Thanks, -- Dana L. How danahow@gmail.com +1 650 804 5991 cell