From: Dana How <danahow@gmail.com>
Date: Wed, 09 May 2007 16:42:05 GMT
Subject: Re: [PATCH v2] Custom compression levels for objects and packs
Message-ID: <56b7f5510705090942qe574e11h4f52f204d68a40b8@mail.gmail.com>
In-Reply-To: <7vlkfyt13i.fsf@assigned-by-dhcp.cox.net>

On 5/9/07, Junio C Hamano <junkio@cox.net> wrote:
> Nicolas Pitre <nico@cam.org> writes:
>
> > So I suggest that we get rid of core.legacyheaders, preserve the legacy
> > format as the only writable loose object format and deprecate the other
> > one to keep things simpler.  Thoughts?
>
> I agree with your analysis, especially when deeper delta chains
> are allowed, straight copy of loose object becomes less and less
> likely.
I too agree with the logic in the original <tangential comment>,
and deprecation is the appropriate thing.  So I'm not actually
going to change anything here in today's patch.

> > What we need instead is a --no-reuse-object that would force
> > recompression of everything when you really want to enforce a specific
> > compression level across the whole pack(s).
>
> Yeah.  Or maybe --no-reuse to mean both and make '-f' a
> short-hand synonym for that.
>
> I do not see much reason to want to tweak them independently;
> recomputing delta is much more expensive than recompressing
> anyway, and when the user says 'repack -f', it is a sign that
> the user is willing to spend CPU cycles.
We have the same idea about git-repack -f -- it implies both
--no-reuse-delta and --no-reuse-object , and I will do that.
I will incorporate Nicolas's new --no-reuse-object
in my patch to builtin-pack-objects.c .
I won't go so far as collapsing --no-reuse-* to --no-reuse in this patch.

Thanks,
-- 
Dana L. How  danahow@gmail.com  +1 650 804 5991 cell