From: Dana How Date: Mon, 07 May 2007 21:59:49 GMT Subject: Re: [PATCH] Use GIT_OBJECT_DIR for temporary files of pack-objects Message-ID: <56b7f5510705071459pceb8590j47bde5cc6a3e60a0@mail.gmail.com> In-Reply-To: <20070507213347.GB3436@steel.home> On 5/7/07, Alex Riesen wrote: > Dana How, Mon, May 07, 2007 19:51:24 +0200: > > On 5/7/07, Alex Riesen wrote: > > >I'm not sure about fsck cleaning up after crashed/killed pack-objects: > > >not sure I _can_ detect if the temp files really are just leftovers. > > > > It looks like you create temp file in objects , not objects/pack . > > > > So a rule could be : packs left in the former are crashed/killed, > > and packs in the latter are complete? > > How do you know for sure that they are _left_ already? Ah, e.g. you're packing and fsck'ing at the same time? Then you can't know. Never mind... > > You should also look at $PACKTMP in git-repack.sh . > > In it $GIT_DIR should probably be $GIT_OBJECT_DIRECTORY ? > > I think it should, but it is already not the working directory, so my > original complaint does not apply OK, if I have to further change my --max-pack-size patchset which touches git-repack.sh, I'll roll this in. Thanks, -- Dana L. How danahow@gmail.com +1 650 804 5991 cell