From: Dana How Date: Fri, 06 Apr 2007 02:28:20 GMT Subject: Re: [PATCH 08/13] prevent try_delta from using objects not in pack Message-ID: <56b7f5510704051928l5d1f5a02yccc8e57c222e5f64@mail.gmail.com> In-Reply-To: On 4/5/07, Nicolas Pitre wrote: > What is the purpose of this patch? > > The try_delta() function is called with all objects before any object is > written to a pack to find out how to deltify objects upfront. I set no_write for 2 different reasons in the patchset. (1) When the blob is too big (--blob-limit) and will never be written. (2) When the blob has been written to a previous, finished pack. You're correct that this patch will never see condition (2). I think my repository statistics are a little unusual. Perhaps I'm getting ahead of myself here, but I also wanted to experiment with writing all blobs to one set of packs, and all trees, commits, and tags to another set (but probably just one small pack). I would use no_write for that and it would matter here. But I haven't run any experiments yet so I don't know if it makes any difference. I have seen related discussions on the mailing list so I know this isn't a new idea. -- Dana L. How danahow@gmail.com +1 650 804 5991 cell