From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Sat, 13 Sep 2025 21:50:55 GMT
Subject: Re: [PATCH v4 2/7] git: allow alias-shadowing deprecated builtins
Message-ID: <56a5ba02-8bbf-4726-8a76-ca0fb5a38e53@app.fastmail.com>
In-Reply-To: <20250910183418.GA1157772@coredump.intra.peff.net>

On Wed, Sep 10, 2025, at 20:34, Jeff King wrote:
>> Thanks again.  My local test suite passes.  (Except
>> `t5801-remote-helpers.sh` which never works for me.)
>
> I sometimes see failures there because I've checked out and built an old
> version which creates git-remote-testgit as a built script. That was
> later moved into t/t5801 via 5afb2ce4cd (remote-testgit: move it into
> the support directory for t5801, 2019-04-12). But if you have an old
> built copy lying around in the project root, then "git fetch" will find
> that old version first (because it prepends the root GIT_EXEC_PATH to
> PATH when it runs). So we run the old version, which may or may not
> support what the more modern test needs.
>
> And deleting "git-remote-testgit" (or just running "git clean") makes it
> go away.
>
> That may or may not be your problem, of course. ;)

Thanks—that was exactly it.:)