From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Fri, 04 Mar 2016 13:04:16 GMT
Subject: Re: [PATCH 2/2] t5510: do not leave changed cwd
Message-ID: <56D987D0.5030208@drmicha.warpmail.net>
In-Reply-To: <20160304115255.GB8355@sigill.intra.peff.net>

Jeff King venit, vidit, dixit 04.03.2016 12:52:
> On Fri, Mar 04, 2016 at 11:53:50AM +0100, Michael J Gruber wrote:
> 
>> t5510 carefully keeps the cwd at the test root by using either subshells
>> or explicit cd'ing back to the root. Use a subshell for the last
>> subtest, too.
> 
> I doubt this caused the heisenbug you saw, as we should have an absolute
> path for the trash-dir, and we "cd" to its containing directory before
> deleting it. But this is definitely a good thing to be doing anyway, to
> prevent surprises for new tests added to t5510.

Absolutely ;)

Michael