From: Moritz Neeb Date: Sun, 28 Feb 2016 08:03:31 GMT Subject: Re: [PATCH v3 0/7] replacing strbuf_getline_lf() by strbuf_getline() Message-ID: <56D2A9D3.4050303@moritzneeb.de> In-Reply-To: <56D28092.9090209@moritzneeb.de> On 02/28/2016 06:07 AM, Moritz Neeb wrote: > Changes since v2: > > * Line splitting in notes_copy_from_stdin() is changed to string_list_split as > suggested by Eric Sunshine. > * The behavior change in interactive cleaning from patch v2 is undone. > * Some of the previous patches were broken because of some unexpected > whitespace. This should be fixed now. > What I could not yet develop, is a feeling on "how often" to send out new versions of patches. For a small patch like this it feels a bit weird to send out version after version, but maybe that is a good practice? Now that I have implemented some (mainly textual) improvements that came up through the review by Eric, would I rather send out a v4 or wait for comments by other reviewers? Thanks