From: Moritz Neeb Date: Sun, 28 Feb 2016 05:07:30 GMT Subject: [PATCH v3 0/7] replacing strbuf_getline_lf() by strbuf_getline() Message-ID: <56D28092.9090209@moritzneeb.de> In-Reply-To: <56CA5DBB.8040006@moritzneeb.de> This series deals with strbuf_getline_lf() in certain codepaths: Those, where the input that is read, is/was trimmed before doing anything that could possibly expect a CR character. Those places can be assumed to be "text" input, where a CR never would be a meaningful control character. The purpose of this series is to document these places to have this property, by using strbuf_getline() instead of strbuf_getline_lf(). Also in some codepaths, the CR could be a leftover of an editor and is thus removed. Every codepath was examined, if after the change it is still necessary to have trimming or if the additional CRLF-removal suffices. The series is an idea out of [1], where Junio proposed to replace the calls to strbuf_getline_lf() because it 'would [be] a good way to document them as dealing with "text"'. Changes since v2: * Line splitting in notes_copy_from_stdin() is changed to string_list_split as suggested by Eric Sunshine. * The behavior change in interactive cleaning from patch v2 is undone. * Some of the previous patches were broken because of some unexpected whitespace. This should be fixed now. -Moritz [1] http://thread.gmane.org/gmane.comp.version-control.git/284104 Moritz Neeb (7): quote: remove leading space in sq_dequote_step bisect: read bisect paths with strbuf_getline() clean: read user input with strbuf_getline() notes copy --stdin: split lines with string_list_split() notes copy --stdin: read lines with strbuf_getline() remote: read $GIT_DIR/branches/* with strbuf_getline() wt-status: read rebase todolist with strbuf_getline() bisect.c | 5 ++--- builtin/clean.c | 6 +++--- builtin/notes.c | 23 +++++++++++------------ quote.c | 2 ++ remote.c | 2 +- wt-status.c | 3 +-- 6 files changed, 20 insertions(+), 21 deletions(-) -- 2.7.1.346.gc0ef946