From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Thu, 11 Feb 2016 10:03:56 GMT
Subject: Re: [PATCH v4 12/21] refs: allow log-only updates
Message-ID: <56BC5C8C.8060201@alum.mit.edu>
In-Reply-To: <1454701462-3817-13-git-send-email-dturner@twopensource.com>

On 02/05/2016 08:44 PM, David Turner wrote:
> The refs infrastructure learns about log-only ref updates, which only
> update the reflog.  Later, we will use this to separate symbolic
> reference resolution from ref updating.

This looks good. I assume it will get some testing later in the series.

> [...]
> diff --git a/refs/refs-internal.h b/refs/refs-internal.h
> index fc5d1db..b5d0ab8 100644
> --- a/refs/refs-internal.h
> +++ b/refs/refs-internal.h
> @@ -42,6 +42,8 @@
>   * value to ref_update::flags
>   */
>  
> +#define REF_LOG_ONLY 0x80
> +

Please add a comment explaining the meaning/purpose of this flag.

> [...]

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu