From: Moritz Neeb Date: Sat, 30 Jan 2016 18:03:47 GMT Subject: [PATCH 1/5] bisect: read bisect paths with strbuf_getline() Message-ID: <56ACFB03.3020000@moritzneeb.de> In-Reply-To: <56ACF82B.2030005@moritzneeb.de> The lines read from BISECT_NAMES are trimmed with strbuf_trim() immediately. There is thus no logic expecting CR, so strbuf_getline_lf() can be replaced by its CRLF counterpart. Signed-off-by: Moritz Neeb --- bisect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bisect.c b/bisect.c index 06ec54e..bf7c885 100644 --- a/bisect.c +++ b/bisect.c @@ -440,7 +440,7 @@ static void read_bisect_paths(struct argv_array *array) if (!fp) die_errno("Could not open file '%s'", filename); - while (strbuf_getline_lf(&str, fp) != EOF) { + while (strbuf_getline(&str, fp) != EOF) { strbuf_trim(&str); if (sq_dequote_to_argv_array(str.buf, array)) die("Badly quoted content in file '%s': %s", -- 2.4.3