From: Ramsay Jones Date: Wed, 13 Jan 2016 16:44:37 GMT Subject: Re: [PATCH v4 3/4] Provide a dirname() function when NO_LIBGEN_H=YesPlease Message-ID: <56967EF5.60202@ramsayjones.plus.com> In-Reply-To: On 13/01/16 07:40, Johannes Schindelin wrote: > Hi Ramsay, > > On Wed, 13 Jan 2016, Ramsay Jones wrote: > >> Also, when compiling on Cygwin with NO_LIBGEN_H, I need to >> include the following here: >> >> #undef basename >> >> in order to suppress approx 230 warnings about the redefinition >> of the basename macro. >> >> (I suppose that should go in the previous commit. dunno) > > I think this is an incorrect use of NO_LIBGEN_H (because Cygwin obviously > has it), but in any case, it is a completely independent issue from > fixing/testing basename()/dirname(), so your #undef basename should be in > a completely separate commit, methinks. OK. I think this worked fine on 32-bit cygwin, but the system headers have changed quite a bit on 64-bit cygwin and I only tried it for the first time yesterday. (It was helpful in the debugging process at one point to be able to build with NO_LIBGEN_H on all platforms ...) ATB, Ramsay Jones