From: Torsten Bögershausen <tboegi@web.de>
Date: Tue, 24 Nov 2015 05:57:33 GMT
Subject: Re: [PATCH v4] blame: add support for --[no-]progress option
Message-ID: <5653FC4D.4090201@web.de>
In-Reply-To: <1448327277-29385-1-git-send-email-eantoranz@gmail.com>

On 11/24/2015 02:07 AM, Edmundo Carmona Antoranz wrote:
> diff --git a/builtin/blame.c b/builtin/blame.c
> index 83612f5..1d43b52 100644
> --- a/builtin/blame.c
> +++ b/builtin/blame.c
> @@ -28,6 +28,7 @@
>   #include "line-range.h"
>   #include "line-log.h"
>   #include "dir.h"
> +#include "progress.h"
>   
>   static char blame_usage[] = N_("git blame [<options>] [<rev-opts>] [<rev>] [--] <file>");
>   
> @@ -50,6 +51,7 @@ static int incremental;
>   static int xdl_opts;
>   static int abbrev = -1;
>   static int no_whole_file_rename;
> +static int show_progress;
>   
>   static struct date_mode blame_date_mode = { DATE_ISO8601 };
>   static size_t blame_date_width;
> @@ -127,6 +129,11 @@ struct origin {
>   	char path[FLEX_ARRAY];
>   };
>   
> +struct progress_info {
> +	struct progress *progress;
> +	int blamed_lines;
> +};
> +
>   static int diff_hunks(mmfile_t *file_a, mmfile_t *file_b, long ctxlen,
>   		      xdl_emit_hunk_consume_func_t hunk_func, void *cb_data)
>   {
> @@ -1746,7 +1753,8 @@ static int emit_one_suspect_detail(struct origin *suspect, int repeat)
>    * The blame_entry is found to be guilty for the range.
>    * Show it in incremental output.
>    */
> -static void found_guilty_entry(struct blame_entry *ent)
> +static void found_guilty_entry(struct blame_entry *ent,
> +			   struct progress_info * pi)
Minor remark: The '*' should be close to the variable: "struct 
progress_info *pi"
>