From: Torsten Bögershausen <tboegi@web.de>
Date: Sat, 21 Nov 2015 06:58:38 GMT
Subject: Re: [PATCHv2] run-command: detect finished children by closed pipe rather than waitpid
Message-ID: <5650161E.9060305@web.de>
In-Reply-To: <1448053719-28340-1-git-send-email-sbeller@google.com>

On 2015-11-20 22.08, Stefan Beller wrote:
The patch looks good at first glance, one minor remark below:
> 
> diff --git a/run-command.c b/run-command.c

> @@ -1071,70 +1089,31 @@ static void pp_output(struct parallel_processes *pp)
>  
>  static int pp_collect_finished(struct parallel_processes *pp)
>  {
> -	int i = 0;
> -	pid_t pid;
> -	int wait_status, code;
> +	int i, code;

code is probably "return code"?
woud "ret_value", "res" or "rc" make that more clear ?