From: Jens Lehmann <jens.lehmann@web.de>
Date: Mon, 16 Nov 2015 19:05:42 GMT
Subject: Re: [PATCH] push: add recurseSubmodules config option
Message-ID: <564A2906.7010902@web.de>
In-Reply-To: <20151116183106.GA31731@mcrowe.com>

Am 16.11.2015 um 19:31 schrieb Mike Crowe:
> On Monday 16 November 2015 at 10:15:24 -0800, Stefan Beller wrote:
>> The code itself looks good to me, one nit in the tests though.
>>
>>> @@ -79,6 +87,119 @@ test_expect_success 'push succeeds after commit was pushed to remote' '
>>>          )
>>>   '
>>>
>>> +test_expect_success 'push succeeds if submodule commit not on remote but using on-demand on command line' '
>>> +       (
>>> +               cd work/gar/bage &&
>>> +               >recurse-on-demand-on-command-line &&
>>> +               git add recurse-on-demand-on-command-line &&
>>> +               git commit -m "Recurse on-demand on command line junk"
>>> +       ) &&
>>> +       (
>>> +               cd work &&
>>> +               git add gar/bage &&
>>> +               git commit -m "Recurse on-demand on command line for gar/bage" &&
>>> +               git push --recurse-submodules=on-demand ../pub.git master &&
>>> +               # Check that the supermodule commit got there
>>> +               git fetch ../pub.git &&
>>> +               git diff --quiet FETCH_HEAD master
>>
>> Missing && chain here.
>
> Oh, well spotted! I'll provide an updated version.

Looking good for me too!

Cool, another issue from my Wiki that's being worked on!