From: Luke Diamand Date: Sat, 24 Oct 2015 19:07:53 GMT Subject: Re: [PATCH v1] git-p4: Add option to ignore empty commits Message-ID: <562BD709.1020307@diamand.org> In-Reply-To: On 24/10/15 17:28, Lars Schneider wrote: > >> Also I have this suspicion that those who do want to use client spec >> to get a narrowed view into the history would almost always want >> this "ignore empty" behaviour (I'd even say the current behaviour to >> leave empty commits by default is a bug). What are the advantages >> of keeping empty commits? If there aren't many, perhaps git-p4 >> should by the default skip empties and require p4.keepEmpty >> configuration to keep them? > > I agree. > @Luke: What option do you prefer? "git-p4.keepEmptyCommits" or "git-p4.ignoreEmptyCommits" ? keepEmptyCommits.