From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Tue, 13 Oct 2015 07:44:28 GMT
Subject: Re: [PATCH v3 20/44] refs-be-files.c: add methods for misc ref operations
Message-ID: <561CB65C.4040902@alum.mit.edu>
In-Reply-To: <1444686725-27660-22-git-send-email-dturner@twopensource.com>

On 10/12/2015 11:51 PM, David Turner wrote:
> From: Ronnie Sahlberg <sahlberg@google.com>
> 
> Add ref backend methods for:
> resolve_ref_unsafe, verify_refname_available, pack_refs, peel_ref,
> create_symref, resolve_gitlink_ref.
> 
> Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
> Signed-off-by: David Turner <dturner@twitter.com>
> ---
>  builtin/init-db.c |  1 +
>  cache.h           |  7 +++++++
>  refs-be-files.c   | 36 +++++++++++++++++++++++++++---------
>  refs.c            | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  refs.h            | 18 ++++++++++++++++++
>  5 files changed, 100 insertions(+), 9 deletions(-)

This commit doesn't build:

refs-be-files.c:3636:2: error: initialization from incompatible pointer
type [-Werror]
  files_create_symref,
  ^
refs-be-files.c:3636:2: error: (near initialization for
‘refs_be_files.create_symref’) [-Werror]

Apparently one of the hunks from the subsequent commit is needed in this
commit.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu