From: Luke Diamand <luke@diamand.org>
Date: Mon, 21 Sep 2015 19:34:53 GMT
Subject: Re: [PATCH v3] git-p4: use replacement character for non UTF-8 characters in paths
Message-ID: <56005BDD.6050508@diamand.org>
In-Reply-To: <1442825358-90294-1-git-send-email-larsxschneider@gmail.com>

On 21/09/15 09:49, larsxschneider@gmail.com wrote:
> From: Lars Schneider <larsxschneider@gmail.com>
>
> I broke a test in "[PATCH v2] git-p4: improve path encoding verbose output" on the next branch.
> This patch on top of next (3dd15c0) fixes the issue.
>
> Thanks to Luke for finding the issue!

Looks good to me, apart from using a UTF-8 char in the comment itself, 
which seems a bit unnecessary. Imagine what will happen to someone using 
git-p4 to mirror git-p4 itself into p4!


>
> Cheers,
> Lars
>
> Lars Schneider (1):
>    git-p4: use replacement character for non UTF-8 characters in paths
>
>   git-p4.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.5.1
>