From: Phillip Wood <phillip.wood@talktalk.net>
Date: Fri, 26 Oct 2018 09:00:03 GMT
Subject: Re: [PATCH v2 0/5] am/rebase: share read_author_script()
Message-ID: <55a2a458-c71e-0018-5fd7-b66e349ddb3d@talktalk.net>
In-Reply-To: <xmqqtvlah052.fsf@gitster-ct.c.googlers.com>

Hi Junio

On 25/10/2018 09:59, Junio C Hamano wrote:
> Phillip Wood <phillip.wood@talktalk.net> writes:
> 
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> Thanks to Eric for his feedback on v1. I've rerolled based on
>> that. Patches 1 & 2 are new and try to address some of the concerns
>> Eric raised, particularly the error handling for a badly edited author
>> script. See the notes on patches 4 & 5 for the changes to those (they
>> were previously 2 & 3).
> 
> I spotted a weird corner case buglet, but it seems that this one is
> ready for 'next' even without fixing that "give it three times and
> we will happily continue" thing.

Well spotted on the corner case. If you're happy to hold off on moving
it to next I can send a re-roll with fixes for that next week or I can
do it as a fixup if you want to move this forward now.

> Do we know of any other issues?  Can we now move it forward?

I don't know of any other issues but I don't think anyone else has
looked at this iteration. Thanks for taking a look at these.

Best Wishes

Phillip



> Thanks.
>