From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Wed, 05 Aug 2015 08:49:11 GMT
Subject: Re: [PATCH 2/2] clone: use computed length in guess_dir_name
Message-ID: <55C1CE07.9010602@gmail.com>
In-Reply-To: <20150805083945.GB28212@sigill.intra.peff.net>

On 8/5/2015 10:39, Jeff King wrote:

> Commit 7e837c6 (clone: simplify string handling in
> guess_dir_name(), 2015-07-09) changed clone to use
> strip_suffix instead of hand-rolled pointer manipulation.
> However, strip_suffix will strip from the end of a
> NUL-terminated string, and we may have already stripped some
> characters (like directory separators, or "/.git"). This
> leads to commands like:
> 
>    git clone host:foo.git/
> 
> failing to strip the ".git".

Thanks a lot Peff for fixing my bugs, I should have known that you'll be able to come up with something much sooner than I would ;-)

This all looks good to me!

Regards,
Sebastian