From: Benoit SIGOURE <tsuna@lrde.epita.fr>
Date: Mon, 17 Sep 2007 23:52:21 GMT
Subject: Re: commit summary, --pretty=short and other tools
Message-ID: <55887C88-8523-4839-8B91-236256A5E893@lrde.epita.fr>
In-Reply-To: <20070917112136.GA30201@glandium.org>

On Sep 17, 2007, at 1:21 PM, Mike Hommey wrote:

> Hi,
>
> I kind of shot myself in the foot with how to type proper commit
> messages.
>
> The git-commit manual page reads:
>   Though not required, it´s a good idea to begin the commit message  
> with a
>   single short (less than 50 character) line summarizing the change,
>   followed by a blank line and then a more thorough description.
>
> ... and I happen to not have done the "followed by a blank line" part.
>
[...]
> What do you think ?

I started using Git as a "better SVN client" and didn't follow this  
"good idea".  The thing, as I already pointed out on IRC, these a are  
more rules than just guidelines.  Some tools (such as rebase) enforce  
them.  That is, they rewrite commit messages.  I found this extremely  
annoying (Junio provided a patch but I don't know whether it's been  
applied, I personally use it in my Git).

See this thread: http://marc.info/?t=118561729500001&r=1&w=2

My opinion is that it would be better to keep the first line and  
never ever rewrite the commit messages.

Cheers,

-- 
Benoit Sigoure aka Tsuna
EPITA Research and Development Laboratory