From: Karthik Nayak <karthik.188@gmail.com>
Date: Mon, 08 Jun 2015 18:33:03 GMT
Subject: Re: [PATCH v6 01/11] for-each-ref: extract helper functions out of grab_single_ref()
Message-ID: <5575DFDF.7000404@gmail.com>
In-Reply-To: <xmqqlhfuaxjw.fsf@gitster.dls.corp.google.com>

On 06/08/2015 11:32 PM, Junio C Hamano wrote:
> Karthik Nayak <karthik.188@gmail.com> writes:
>
>> + * Given a refname, return 1 if the refname matches with one of the patterns
>
> You can "match refname with pattern".  But "refname matches the
> pattern" without "with", I think.
>
> I am not a native, though.
>
>> + * while the pattern is a pathname like 'refs/tags' or 'refs/heads/master'
>> + * and so on, else return 0. Supports use of wild characters.
>
> s/wild/wildcard/.
>
> 	Return 1 if the refname matches with one of the patterns,
> 	otherwise 0.  The patterns can be literal prefix (e.g. a
> 	refname "refs/heads/master" matches a pattern "refs/heads/")
> 	or a wildcard (e.g. the same ref matches "refs/heads/m*",
> 	too).
>
> perhaps?
>

Sounds a lot better, thanks :)

-- 
Regards,
Karthik